Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation] Remove the deprecated Store trait #3532

Merged
merged 22 commits into from
Mar 11, 2024

Conversation

philoniare
Copy link
Contributor

Description

Removes the deprecated trait Store feature from the code base

Fixes #222

@philoniare philoniare changed the title [Deprecation] Remove the deprecated store trait [Deprecation] Remove the deprecated Store trait Feb 29, 2024
@philoniare philoniare marked this pull request as ready for review February 29, 2024 20:23
@philoniare philoniare requested a review from a team as a code owner February 29, 2024 20:23
prdoc/pr_3532.prdoc Outdated Show resolved Hide resolved
prdoc/pr_3532.prdoc Outdated Show resolved Hide resolved
philoniare and others added 2 commits March 1, 2024 20:08
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
@seadanda seadanda added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Mar 1, 2024
@philoniare philoniare requested a review from ggwpez March 2, 2024 15:16
@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 2, 2024 15:17
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but need to double check previous deprecation PR actually added the deprecated flag to emit a warning upon use.

prdoc/pr_3532.prdoc Outdated Show resolved Hide resolved
substrate/frame/support/procedural/src/lib.rs Show resolved Hide resolved
@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 4, 2024 10:38
prdoc/pr_3532.prdoc Outdated Show resolved Hide resolved
@philoniare
Copy link
Contributor Author

Looks ready for a merge. Would be great if someone with the perms could add it to the merge queue

@bkchr bkchr added this pull request to the merge queue Mar 11, 2024
Merged via the queue into paritytech:master with commit d3f8105 Mar 11, 2024
130 of 131 checks passed
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024
# Description

*Removes the deprecated `trait Store` feature from the code base*

Fixes paritytech#222

---------

Co-authored-by: Dónal Murray <donalm@seadanda.dev>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
# Description

*Removes the deprecated `trait Store` feature from the code base*

Fixes paritytech#222

---------

Co-authored-by: Dónal Murray <donalm@seadanda.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deprecation] deprecate trait Store in FRAME storage
5 participants