-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecation] Remove the deprecated Store trait #3532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philoniare
changed the title
[Deprecation] Remove the deprecated store trait
[Deprecation] Remove the deprecated Store trait
Feb 29, 2024
seadanda
reviewed
Mar 1, 2024
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
seadanda
added
the
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
label
Mar 1, 2024
ggwpez
reviewed
Mar 1, 2024
kianenigma
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but need to double check previous deprecation PR actually added the deprecated flag to emit a warning upon use.
ggwpez
approved these changes
Mar 4, 2024
seadanda
approved these changes
Mar 5, 2024
Looks ready for a merge. Would be great if someone with the perms could add it to the merge queue |
bkchr
approved these changes
Mar 11, 2024
Merged
via the queue into
paritytech:master
with commit Mar 11, 2024
d3f8105
130 of 131 checks passed
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Mar 24, 2024
# Description *Removes the deprecated `trait Store` feature from the code base* Fixes paritytech#222 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
# Description *Removes the deprecated `trait Store` feature from the code base* Fixes paritytech#222 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev>
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the deprecated
trait Store
feature from the code baseFixes #222